Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8076 )
Change subject: IMPALA-4786: Clean up how ImpalaServers are created ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/8076/2/be/src/service/impala-server.h File be/src/service/impala-server.h: http://gerrit.cloudera.org:8080/#/c/8076/2/be/src/service/impala-server.h@999 PS2, Line 999: /// Init() were <= 0. > add to comment: Done http://gerrit.cloudera.org:8080/#/c/8076/2/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/8076/2/be/src/service/impala-server.cc@2078 PS2, Line 2078: } > i think we still need to reset these pointers since they hold a shared_ptr Done -- To view, visit http://gerrit.cloudera.org:8080/8076 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If388c5618258a9c4529cd1d63e956566b92bd0d8 Gerrit-Change-Number: 8076 Gerrit-PatchSet: 3 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Comment-Date: Tue, 26 Sep 2017 14:38:41 +0000 Gerrit-HasComments: Yes
