Csaba Ringhofer has posted comments on this change. Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7954/2/be/src/runtime/timestamp-value.h File be/src/runtime/timestamp-value.h: PS2, Line 80: !date_.is_special() > I looked at ScalarColumnReader<TimestampValue, true>::ValidateSlot(), and n I think that ScalarColumnReader<TimestampValue, true>::ValidateSlot() is actually a bit too strict, which lead to inconsistency between text and parquet files. I have created a ticket for this: https://issues.apache.org/jira/browse/IMPALA-5942 We should decide the correct behavior in these cases, before continuing with this ticket. -- To view, visit http://gerrit.cloudera.org:8080/7954 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77b2f6284d3a597f57e61c17a67c959eff9e38ff Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-HasComments: Yes
