Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/7954 )
Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/7954/4/be/src/runtime/timestamp-value.h File be/src/runtime/timestamp-value.h: http://gerrit.cloudera.org:8080/#/c/7954/4/be/src/runtime/timestamp-value.h@173 PS4, Line 173: > i think it would be best to avoid running the constructor given these thing Done http://gerrit.cloudera.org:8080/#/c/7954/4/be/src/runtime/timestamp-value.h@287 PS4, Line 287: > nit: extraneous space Done http://gerrit.cloudera.org:8080/#/c/7954/2/be/src/runtime/timestamp-value.h File be/src/runtime/timestamp-value.h: http://gerrit.cloudera.org:8080/#/c/7954/2/be/src/runtime/timestamp-value.h@86 PS2, Line 86: } > Logging in the caller is fine but I don't see that added to your diff. I have added some logging, but not on the caller side. -- To view, visit http://gerrit.cloudera.org:8080/7954 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I77b2f6284d3a597f57e61c17a67c959eff9e38ff Gerrit-Change-Number: 7954 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Comment-Date: Fri, 29 Sep 2017 16:40:38 +0000 Gerrit-HasComments: Yes