Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/7954 )
Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/7954/2/be/src/exprs/timestamp-functions-ir.cc File be/src/exprs/timestamp-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/7954/2/be/src/exprs/timestamp-functions-ir.cc@332 PS2, Line 332: StringVal result(context, 10); why does this DCHECK no longer make sense? are we saying it's trivially true now after check HasDate() and with the checks you've added in this commit? http://gerrit.cloudera.org:8080/#/c/7954/4/be/src/runtime/timestamp-value.h File be/src/runtime/timestamp-value.h: http://gerrit.cloudera.org:8080/#/c/7954/4/be/src/runtime/timestamp-value.h@173 PS4, Line 173: boost::gregorian::date i think it would be best to avoid running the constructor given these things can throw exceptions, so let's use 'const &' here. http://gerrit.cloudera.org:8080/#/c/7954/4/be/src/runtime/timestamp-value.h@287 PS4, Line 287: nit: extraneous space http://gerrit.cloudera.org:8080/#/c/7954/2/be/src/runtime/timestamp-value.h File be/src/runtime/timestamp-value.h: http://gerrit.cloudera.org:8080/#/c/7954/2/be/src/runtime/timestamp-value.h@86 PS2, Line 86: /// Constructors that parse from a date/time string. See TimestampParser for details > I think it would be better to do the logging on the caller side, because de Logging in the caller is fine but I don't see that added to your diff. -- To view, visit http://gerrit.cloudera.org:8080/7954 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I77b2f6284d3a597f57e61c17a67c959eff9e38ff Gerrit-Change-Number: 7954 Gerrit-PatchSet: 5 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Comment-Date: Thu, 21 Sep 2017 20:50:20 +0000 Gerrit-HasComments: Yes