Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. ......................................................................
Patch Set 5: Following through on the layering (process options, pool defaults, session options, and request options), there are some complexities. When I changed SetQueryOption(option, "") to reset the mask bit, a new test found that server process options weren't surviving a reset cycle. What's going on is that SessionState.default_query_options is initialized to ImpalaServer.default_query_options, and that resolution is never re-applied. So, when we "reset", we don't handily have a reference to what to reset it to. I'm planning to rename session->default_query_options to session->session_query_options, and resolve against the server defaults every time. -- To view, visit http://gerrit.cloudera.org:8080/8070 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8c383e68064f839cb5000118901dff77b4e5cb9 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
