Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. ......................................................................
Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/8070/7/be/src/service/impala-server.h File be/src/service/impala-server.h: Line 346: /// Reference to the server's query options I think this is kosher because the server keeps references around to the session. I also considered making a copy for simplicity. Line 392: TQueryOptions query_options(); This is violating our style guide two-fold. First of all, it should be QueryOptions(), which I'll change in the next iteration. Second of all, now we've got two functions in the stuct, and it should be a class. Is it worth it? -- To view, visit http://gerrit.cloudera.org:8080/8070 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8c383e68064f839cb5000118901dff77b4e5cb9 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
