Tim Armstrong has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. ......................................................................
Patch Set 4: That last error looks like an infra issue but it does looks like there was a test failure earlier (I ctrl-fed for "failed"): 20:43:48 ] [ RUN ] QueryOptions.ResetToDefaultViaEmptyString 20:43:48 ] /home/ubuntu/Impala/be/src/service/query-options-test.cc:170: Failure 20:43:48 ] Value of: expectedMask 20:43:48 ] Actual: 0000000000000000000010000000000000000000000000000000000000000000 20:43:48 ] Expected: mask 20:43:48 ] Which is: 0000000000000000000000000000000000000000000000000000000000000000 20:43:48 ] [ FAILED ] QueryOptions.ResetToDefaultViaEmptyString (0 ms) -- To view, visit http://gerrit.cloudera.org:8080/8070 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8c383e68064f839cb5000118901dff77b4e5cb9 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
