Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8122 )
Change subject: IMPALA-1767 Adds predicate to test boolean values true, false, unknown. ...................................................................... Patch Set 4: (1 comment) Nice, almost done http://gerrit.cloudera.org:8080/#/c/8122/1/fe/src/main/cup/sql-parser.cup File fe/src/main/cup/sql-parser.cup: http://gerrit.cloudera.org:8080/#/c/8122/1/fe/src/main/cup/sql-parser.cup@2731 PS1, Line 2731: {: > Changed it to bool_value_expr to be consistent with the standard. How did you conclude that bool_value_expr is the standard terminology? My understanding is that the bool_test_expr you had before is more consistent with what Greg posted in the JIRA. If you don't like truth_test_expr (which is fine), I prefer the bool_test_expr over bool_value_expr. -- To view, visit http://gerrit.cloudera.org:8080/8122 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d5fba65ef6c87dfc55a25d2c45246f74eb48c40 Gerrit-Change-Number: 8122 Gerrit-PatchSet: 4 Gerrit-Owner: Vuk Ercegovac <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Fri, 22 Sep 2017 23:14:39 +0000 Gerrit-HasComments: Yes
