Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8122 )
Change subject: IMPALA-1767 Adds predicate to test boolean values true, false, unknown. ...................................................................... IMPALA-1767 Adds predicate to test boolean values true, false, unknown. Adds a new expression to represent the following boolean predicate: <expr> IS [NOT] (TRUE | FALSE | UNKNOWN) The expression is expanded in the parser to istrue/false for the checks against true and false respectively and to isnull for the check against unknown. Compared to the other approaches (rewrites, extended backend expr), this change is the simplest. Main downside is that error messages are in terms of the lowered expression. Testing: - fe: parser, tosql, analyze exprs - e2e: query exprs Change-Id: I9d5fba65ef6c87dfc55a25d2c45246f74eb48c40 Reviewed-on: http://gerrit.cloudera.org:8080/8122 Reviewed-by: Alex Behm <alex.b...@cloudera.com> Tested-by: Impala Public Jenkins --- M be/src/exprs/expr-test.cc M fe/src/main/cup/sql-parser.cup M fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java M fe/src/test/java/org/apache/impala/analysis/ParserTest.java M fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java M testdata/workloads/functional-query/queries/QueryTest/exprs.test 6 files changed, 184 insertions(+), 8 deletions(-) Approvals: Alex Behm: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/8122 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I9d5fba65ef6c87dfc55a25d2c45246f74eb48c40 Gerrit-Change-Number: 8122 Gerrit-PatchSet: 7 Gerrit-Owner: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com>
