Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8122 )
Change subject: IMPALA-1767 Adds predicate to test boolean values true, false, unknown. ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/8122/1/fe/src/main/cup/sql-parser.cup File fe/src/main/cup/sql-parser.cup: http://gerrit.cloudera.org:8080/#/c/8122/1/fe/src/main/cup/sql-parser.cup@2731 PS1, Line 2731: {: > How did you conclude that bool_value_expr is the standard terminology? My u I took the name one-level too high in the spec-- thx for pointing it out. Agreed that bool_test_expr is a better name so going with that (made the change in several places). -- To view, visit http://gerrit.cloudera.org:8080/8122 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d5fba65ef6c87dfc55a25d2c45246f74eb48c40 Gerrit-Change-Number: 8122 Gerrit-PatchSet: 5 Gerrit-Owner: Vuk Ercegovac <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Fri, 22 Sep 2017 23:43:45 +0000 Gerrit-HasComments: Yes
