Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/8100 )
Change subject: IMPALA-5940: Avoid log spew by using Status::Expected. ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8100/2/be/src/runtime/client-cache.h File be/src/runtime/client-cache.h: http://gerrit.cloudera.org:8080/#/c/8100/2/be/src/runtime/client-cache.h@243 PS2, Line 243: return Status::NoTrace(TErrorCode::RPC_RECV_TIMEOUT, strings::Substitute( Is it necessary to have Status write the message to the log? is it not sufficient to write an info message via LOG.info. -- To view, visit http://gerrit.cloudera.org:8080/8100 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I38088482377a1c3e794a9c8178ef83f29957a330 Gerrit-Change-Number: 8100 Gerrit-PatchSet: 2 Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Tue, 26 Sep 2017 23:08:09 +0000 Gerrit-HasComments: Yes
