Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8100 )
Change subject: IMPALA-5940: Avoid log spew by using Status::Expected. ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/8100/3/be/src/exec/hdfs-avro-scanner.cc File be/src/exec/hdfs-avro-scanner.cc: http://gerrit.cloudera.org:8080/#/c/8100/3/be/src/exec/hdfs-avro-scanner.cc@972 PS3, Line 972: return Status::Expected(Substitute( > Yes that's correct. I double-checked a variant here. It shows up there. (It's not from this Avro code path, but they're similar. I wasn't able to quickly find an avro test table with the right types...) [philip-dev.gce.cloudera.com:21000] > use functional_rc; Query: use functional_rc [philip-dev.gce.cloudera.com:21000] > create table t2 as select * from alltypes; Query: create table t2 as select * from alltypes ... HDFS_SCAN_NODE (id=0):(Total: 35.999ms, non-child: 35.999ms, % non-child: 100.00%) Hdfs split stats (<volume id>:<# splits>/<split lengths>): -1:8/140.12 KB ExecOption: RC_FILE Codegen Disabled: Not implemented for this format. http://gerrit.cloudera.org:8080/#/c/8100/3/be/src/runtime/client-cache.h File be/src/runtime/client-cache.h: http://gerrit.cloudera.org:8080/#/c/8100/3/be/src/runtime/client-cache.h@243 PS3, Line 243: string err = strings::Substitute("Client $0 timed-out during recv call.", TNetworkAddressToString(address_)); > long line done. http://gerrit.cloudera.org:8080/#/c/8100/3/be/src/runtime/client-cache.h@281 PS3, Line 281: return Status::Expected(ErrorMsg(TErrorCode::RPC_RECV_TIMEOUT, err)); > same set of comment/question done. http://gerrit.cloudera.org:8080/#/c/8100/3/be/src/runtime/tuple.cc File be/src/runtime/tuple.cc: http://gerrit.cloudera.org:8080/#/c/8100/3/be/src/runtime/tuple.cc@309 PS3, Line 309: stringstream ss; : ss << "Could not codegen CodegenMaterializeExprs: " << status.GetDetail(); > okay to ignore, but could clean that up with Substitute() Done -- To view, visit http://gerrit.cloudera.org:8080/8100 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I38088482377a1c3e794a9c8178ef83f29957a330 Gerrit-Change-Number: 8100 Gerrit-PatchSet: 3 Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 29 Sep 2017 19:51:08 +0000 Gerrit-HasComments: Yes
