Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8100 )
Change subject: IMPALA-5940: Avoid log spew by using Status::Expected. ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8100/3/be/src/runtime/client-cache.h File be/src/runtime/client-cache.h: http://gerrit.cloudera.org:8080/#/c/8100/3/be/src/runtime/client-cache.h@246 PS3, Line 246: return Status::Expected(ErrorMsg(TErrorCode::RPC_RECV_TIMEOUT, err)); > I think it should be fine, since we re-log the error here anyway: That re-log of the error doesn't include the backtrace though. So I don't think it has bearing on whether eliminating the backtrace is okay. That said, it's probably still okay to avoid the BT here. -- To view, visit http://gerrit.cloudera.org:8080/8100 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I38088482377a1c3e794a9c8178ef83f29957a330 Gerrit-Change-Number: 8100 Gerrit-PatchSet: 3 Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Comment-Date: Tue, 03 Oct 2017 17:34:00 +0000 Gerrit-HasComments: Yes
