Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/7938 )
Change subject: IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/7938/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/7938/4//COMMIT_MSG@21 PS4, Line 21: Converted existing tests in thrift-server-test to run with and : without kerberos. we can also add tests that run with and without FLAGS_use_krpc_kinit set to make sure both paths work and also make sure that KRPC's Kinit was successful. http://gerrit.cloudera.org:8080/#/c/7938/4/be/src/rpc/thrift-server-test.cc File be/src/rpc/thrift-server-test.cc: http://gerrit.cloudera.org:8080/#/c/7938/4/be/src/rpc/thrift-server-test.cc@129 PS4, Line 129: ASSERT_TRUE(kudu::Env::Default()->GetExecutablePath(¤t_executable_path).ok()) since this assert is done a bunch of times here and would probably be done more in the future as we have added the KPRC code, would it make sense to add a macro for this (for kudu:status object) like we have ASSERT_OK for the impala:status object? -- To view, visit http://gerrit.cloudera.org:8080/7938 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9cea56cc6e7412d87f4c2e92399a2f91ea6af6c7 Gerrit-Change-Number: 7938 Gerrit-PatchSet: 4 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Comment-Date: Thu, 28 Sep 2017 21:38:27 +0000 Gerrit-HasComments: Yes
