Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/7938 )
Change subject: IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/7938/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/7938/4//COMMIT_MSG@21 PS4, Line 21: Converted existing tests in thrift-server-test to run with and : without kerberos. > we can also add tests that run with and without FLAGS_use_krpc_kinit set to Done http://gerrit.cloudera.org:8080/#/c/7938/4/be/src/rpc/thrift-server-test.cc File be/src/rpc/thrift-server-test.cc: http://gerrit.cloudera.org:8080/#/c/7938/4/be/src/rpc/thrift-server-test.cc@129 PS4, Line 129: FLAGS_krb5_conf = Substitute("$0/$1", keytab_dir, "krb5.conf"); > since this assert is done a bunch of times here and would probably be done Good point. We have a FromKuduStatus() function which will come in with Michael's RpcMgr patch here: https://gerrit.cloudera.org/#/c/7901/9/be/src/exec/kudu-util.h I'll add it for now and it in this patch as well and use it; and it should resolve itself in the rebase after his patch is merged in. -- To view, visit http://gerrit.cloudera.org:8080/7938 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9cea56cc6e7412d87f4c2e92399a2f91ea6af6c7 Gerrit-Change-Number: 7938 Gerrit-PatchSet: 5 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Comment-Date: Thu, 05 Oct 2017 23:27:38 +0000 Gerrit-HasComments: Yes
