Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/7938 )
Change subject: IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/7938/5/be/src/kudu/security/init.cc File be/src/kudu/security/init.cc: http://gerrit.cloudera.org:8080/#/c/7938/5/be/src/kudu/security/init.cc@460 PS5, Line 460: //setenv("KRB5CCNAME", "MEMORY:kudu", 1); : //setenv("KRB5_KTNAME", FLAGS_keytab_file.c_str(), 1); : // We commented out the above since we don't want to overwrite our own Impala : // set environment variables. Is this function used for testing only ? If so, would it be better to move it to the tests in the Kudu side too to avoid unnecessary divergence in the code ? http://gerrit.cloudera.org:8080/#/c/7938/5/be/src/kudu/security/init.cc@469 PS5, Line 469: //setenv("KRB5RCACHETYPE", "none", 1); Same comment. -- To view, visit http://gerrit.cloudera.org:8080/7938 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9cea56cc6e7412d87f4c2e92399a2f91ea6af6c7 Gerrit-Change-Number: 7938 Gerrit-PatchSet: 5 Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Mon, 09 Oct 2017 18:42:39 +0000 Gerrit-HasComments: Yes
