Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/7438 )
Change subject: IMPALA-4939, IMPALA-4940: Decimal V2 multiplication ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/7438/7/be/src/runtime/decimal-value.inline.h File be/src/runtime/decimal-value.inline.h: http://gerrit.cloudera.org:8080/#/c/7438/7/be/src/runtime/decimal-value.inline.h@249 PS7, Line 249: } else { > maybe a quick comment: Yes, your understanding is correct. Added comment. -- To view, visit http://gerrit.cloudera.org:8080/7438 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37ad6232d7953bd75c18dc86e665b2b501a1ebe1 Gerrit-Change-Number: 7438 Gerrit-PatchSet: 7 Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-Comment-Date: Tue, 03 Oct 2017 02:53:19 +0000 Gerrit-HasComments: Yes
