Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/7438 )
Change subject: IMPALA-4939, IMPALA-4940: Decimal V2 multiplication ...................................................................... Patch Set 7: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/7438/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/7438/6//COMMIT_MSG@67 PS6, Line 67: after: 126.17s > No, not always. Look at line 73 in this file. Yeah, but that's "just" 2x, as opposed to 10x. http://gerrit.cloudera.org:8080/#/c/7438/7/be/src/runtime/decimal-value.inline.h File be/src/runtime/decimal-value.inline.h: http://gerrit.cloudera.org:8080/#/c/7438/7/be/src/runtime/decimal-value.inline.h@249 PS7, Line 249: } else { maybe a quick comment: // We've verified the intermediate value will fit in int128. is my understanding correct? -- To view, visit http://gerrit.cloudera.org:8080/7438 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37ad6232d7953bd75c18dc86e665b2b501a1ebe1 Gerrit-Change-Number: 7438 Gerrit-PatchSet: 7 Gerrit-Owner: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zach Amsden <zams...@cloudera.com> Gerrit-Comment-Date: Mon, 02 Oct 2017 22:29:16 +0000 Gerrit-HasComments: Yes
