Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/7438 )
Change subject: IMPALA-4939, IMPALA-4940: Decimal V2 multiplication ...................................................................... Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080/#/c/7438/8/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: http://gerrit.cloudera.org:8080/#/c/7438/8/be/src/exprs/expr-test.cc@1672 PS8, Line 1672: not require int256. > if result does not require int256, why does it overflow (return null)? Added comment. http://gerrit.cloudera.org:8080/#/c/7438/8/be/src/exprs/expr-test.cc@1675 PS8, Line 1675: { true, 0, 38, 0 }}}, > when both V1 and V2 give the same answer, you don't have to include both re Done http://gerrit.cloudera.org:8080/#/c/7438/8/be/src/exprs/expr-test.cc@1680 PS8, Line 1680: { "cast(18446744073709551615 as decimal(38,0)) * cast(9223372036854775808 as decimal(38,0))", > It might be helpful if you mentioned how these values where computed in the Added comment. http://gerrit.cloudera.org:8080/#/c/7438/8/be/src/exprs/expr-test.cc@1702 PS8, Line 1702: 85070591730234615865843651857942052864 > how did you verify these results? I used Python to make sure I get the same results. -- To view, visit http://gerrit.cloudera.org:8080/7438 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37ad6232d7953bd75c18dc86e665b2b501a1ebe1 Gerrit-Change-Number: 7438 Gerrit-PatchSet: 8 Gerrit-Owner: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zach Amsden <zams...@cloudera.com> Gerrit-Comment-Date: Tue, 03 Oct 2017 21:26:14 +0000 Gerrit-HasComments: Yes
