Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8196 )
Change subject: IMPALA-4236: Codegen CopyRows() for select nodes ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8196/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8196/1//COMMIT_MSG@8 PS1, Line 8: > is there anyway we can make sure through a test that codegen was successful as discussed, I have added the test to check the query profile -- To view, visit http://gerrit.cloudera.org:8080/8196 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0d496d004418468e16b6f564f90f45ebbf87c1e Gerrit-Change-Number: 8196 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 03 Oct 2017 22:54:54 +0000 Gerrit-HasComments: Yes
