Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8196 )
Change subject: IMPALA-4236: Codegen CopyRows() for select nodes ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/8196/4/be/src/exec/select-node.cc File be/src/exec/select-node.cc: http://gerrit.cloudera.org:8080/#/c/8196/4/be/src/exec/select-node.cc@113 PS4, Line 113: copy_rows_result; > I think it would still be better to have a name that makes the below contro removed. see below comment. http://gerrit.cloudera.org:8080/#/c/8196/4/be/src/exec/select-node.cc@120 PS4, Line 120: if (copy_rows_result) { > I think there's an equivalent but simpler way of expressing the control flo You are absolutely right. I have refactored the code which now also make the bool returned by CopyRows() redundant. Therefore I've changed CopyRows()'s return type to void. -- To view, visit http://gerrit.cloudera.org:8080/8196 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0d496d004418468e16b6f564f90f45ebbf87c1e Gerrit-Change-Number: 8196 Gerrit-PatchSet: 4 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Sat, 07 Oct 2017 00:53:46 +0000 Gerrit-HasComments: Yes
