Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8196 )
Change subject: IMPALA-4236: Codegen CopyRows() for select nodes ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/8196/3/be/src/exec/select-node.cc File be/src/exec/select-node.cc: http://gerrit.cloudera.org:8080/#/c/8196/3/be/src/exec/select-node.cc@113 PS3, Line 113: copy_rows_success > (I'm not sure if that description I just gave is accurate or the best way t true! the description is a bit more involved to capture it in a variable name. I think a generic name like "copy_row_result" is good enough and the function description in the header file is sufficient to understand that result. what do u think? http://gerrit.cloudera.org:8080/#/c/8196/3/be/src/exec/select-node.cc@126 PS3, Line 126: if (child_eos_) { > The control flow here is confusing to me. It took me a while to figure out Done http://gerrit.cloudera.org:8080/#/c/8196/3/tests/query_test/test_codegen.py File tests/query_test/test_codegen.py: http://gerrit.cloudera.org:8080/#/c/8196/3/tests/query_test/test_codegen.py@46 PS3, Line 46: codegned > missing an e Done http://gerrit.cloudera.org:8080/#/c/8196/3/tests/query_test/test_codegen.py@51 PS3, Line 51: assert len(exec_options) > This is a matter of taste but generally we prefer being explcit about the c Done -- To view, visit http://gerrit.cloudera.org:8080/8196 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0d496d004418468e16b6f564f90f45ebbf87c1e Gerrit-Change-Number: 8196 Gerrit-PatchSet: 3 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 04 Oct 2017 00:46:19 +0000 Gerrit-HasComments: Yes
