Hello Michael Ho, Dimitris Tsirogiannis, anujphadke, Alex Behm,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8143
to look at the new patch set (#2).
Change subject: IMPALA-4682 Fix IllegalStateException thrown by aggregate
function.
......................................................................
IMPALA-4682 Fix IllegalStateException thrown by aggregate function.
When one runs a query like
'select * from t order by count(a)'
we are incorrectly throwing an IllegalStateException. This is an
invalid query, and we are correctly handling it if "*" is replaced
by a specific column:
'select a from t order by count(b)'
which produces the error message
"ERROR: AnalysisException: select list expression not produced by
aggregation output (missing from GROUP BY clause?): a"
This patch fixes the handling of '*' in this context, so that the
error becomes
"ERROR: AnalysisException: select list expression not produced by
aggregation output (missing from GROUP BY clause?): *"
Note that the second changed line is required because
selectListItem.Expr_ is null when SelectListItem.isStar_ is true.
New FE unit tests are added for this use case.
Change-Id: I57c20aeed401275d45913fedfd61c206c38641b7
---
M fe/src/main/java/org/apache/impala/analysis/SelectStmt.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
2 files changed, 29 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/8143/2
--
To view, visit http://gerrit.cloudera.org:8080/8143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I57c20aeed401275d45913fedfd61c206c38641b7
Gerrit-Change-Number: 8143
Gerrit-PatchSet: 2
Gerrit-Owner: Zoram Thanga <[email protected]>
Gerrit-Reviewer: Alex Behm <[email protected]>
Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]>
Gerrit-Reviewer: Michael Ho <[email protected]>
Gerrit-Reviewer: Zoram Thanga <[email protected]>
Gerrit-Reviewer: anujphadke <[email protected]>
