Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8143 )
Change subject: IMPALA-4682 Fix IllegalStateException thrown by aggregate function. ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8143/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java: http://gerrit.cloudera.org:8080/#/c/8143/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@893 PS2, Line 893: AnalysisError("select l_partkey from tpch_avro.lineitem order by count(l_orderkey)", Test seems to be misplaced and/or duplicated. This test is TestStar() yet there is no star int his query. I suggest you move these tests into TestAggregates() instead and check whether some of these cases are already covered. -- To view, visit http://gerrit.cloudera.org:8080/8143 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57c20aeed401275d45913fedfd61c206c38641b7 Gerrit-Change-Number: 8143 Gerrit-PatchSet: 2 Gerrit-Owner: Zoram Thanga <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Zoram Thanga <[email protected]> Gerrit-Reviewer: anujphadke <[email protected]> Gerrit-Comment-Date: Thu, 05 Oct 2017 00:22:45 +0000 Gerrit-HasComments: Yes
