Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8143 )
Change subject: IMPALA-4682 Fix IllegalStateException thrown by aggregate function. ...................................................................... Patch Set 3: (2 comments) final pass, pretty much done http://gerrit.cloudera.org:8080/#/c/8143/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8143/3//COMMIT_MSG@7 PS3, Line 7: IMPALA-4682 Fix IllegalStateException thrown by aggregate function. Our format is IMPALA-4682: Msg goes here In general, the msg should describe what changed in this patch and not the symptom of the bug. For example, I think the msg here could be improved to: IMPALA-4682: Remove Preconditions check from analyzeAggregation(). http://gerrit.cloudera.org:8080/#/c/8143/3/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java: http://gerrit.cloudera.org:8080/#/c/8143/3/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@1943 PS3, Line 1943: remove newline -- To view, visit http://gerrit.cloudera.org:8080/8143 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57c20aeed401275d45913fedfd61c206c38641b7 Gerrit-Change-Number: 8143 Gerrit-PatchSet: 3 Gerrit-Owner: Zoram Thanga <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Zoram Thanga <[email protected]> Gerrit-Reviewer: anujphadke <[email protected]> Gerrit-Comment-Date: Fri, 06 Oct 2017 04:57:23 +0000 Gerrit-HasComments: Yes
