Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8100 )
Change subject: IMPALA-5940: Avoid log spew by using Status::Expected. ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/8100/3/be/src/runtime/client-cache.h File be/src/runtime/client-cache.h: http://gerrit.cloudera.org:8080/#/c/8100/3/be/src/runtime/client-cache.h@246 PS3, Line 246: > Maybe we should include the RPC name in the log message and that will disam I followed Michael's foot steps and looked at the ~17 callers of DoRpc. Far from all of them log. I'm now proposing we do this patch without the DoRpc() changes. From a performance standpoint, if you're timing out on RPCs, the backtrace is the least of your problems, and, yet, I think knowing which RPC is timing out is very helpful. I wasn't able to see a quick way to get the name of the RPC without discouraged C++ shenanigans. I checked that the Thrift Exception doesn't have that, nor do the Thrift structs seem to have self-identifying information. -- To view, visit http://gerrit.cloudera.org:8080/8100 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I38088482377a1c3e794a9c8178ef83f29957a330 Gerrit-Change-Number: 8100 Gerrit-PatchSet: 6 Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Comment-Date: Fri, 06 Oct 2017 23:28:37 +0000 Gerrit-HasComments: Yes
