Tim Wood has posted comments on this change. ( http://gerrit.cloudera.org:8080/8102 )
Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for Impala. ...................................................................... Patch Set 16: > Patch Set 16: > > > Uploaded patch set 16. > > Pytest shows expanded TPC-DS suite subset passes, but run failed FSR: > https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/412/consoleText IMPALA-5886 explains this. Do we need to front-run this commit with a fix for that? > MM: Did you try DECIMAL_V2 for query_48? Set to 1 or 0, q48 passes for me locally (a single BIGINT value). But I observed it failing in the pre-review run (a different value), so I'd like to resolve q48 in a later commit so it doesn't delay this further. -- To view, visit http://gerrit.cloudera.org:8080/8102 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e284888600a7a69d1f23fcb7dac21cbb13b7d66 Gerrit-Change-Number: 8102 Gerrit-PatchSet: 16 Gerrit-Owner: Tim Wood <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Matthew Mulder <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Wood <[email protected]> Gerrit-Comment-Date: Tue, 10 Oct 2017 01:48:17 +0000 Gerrit-HasComments: No
