Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/8102 )
Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for Impala. ...................................................................... Patch Set 11: (5 comments) http://gerrit.cloudera.org:8080/#/c/8102/17/testdata/workloads/tpcds/queries/tpcds-q28.test File testdata/workloads/tpcds/queries/tpcds-q28.test: http://gerrit.cloudera.org:8080/#/c/8102/17/testdata/workloads/tpcds/queries/tpcds-q28.test@6 PS17, Line 6: from (select truncate(avg(ss_list_price), 2) B1_LP, ss_list_price is decimal(7,2) why is the truncate required here? http://gerrit.cloudera.org:8080/#/c/8102/12/testdata/workloads/tpcds/queries/tpcds-q31.test File testdata/workloads/tpcds/queries/tpcds-q31.test: http://gerrit.cloudera.org:8080/#/c/8102/12/testdata/workloads/tpcds/queries/tpcds-q31.test@4 PS12, Line 4: -- ADDED TRUNCATE(2)s AROUND LAST 4 COLUMNS. Why did this query get taken out? http://gerrit.cloudera.org:8080/#/c/8102/12/testdata/workloads/tpcds/queries/tpcds-q31.test@20 PS12, Line 20: ,truncate(ws2.web_sales/ws1.web_sales, 2) web_q1_q2_increase Also why is truncate here needed? ws_ext_sales_price is a decimal(7,2) http://gerrit.cloudera.org:8080/#/c/8102/12/testdata/workloads/tpcds/queries/tpcds-q5a.test File testdata/workloads/tpcds/queries/tpcds-q5a.test: http://gerrit.cloudera.org:8080/#/c/8102/12/testdata/workloads/tpcds/queries/tpcds-q5a.test@3 PS12, Line 3: with ssr as Why is TPCDS-5A removed? http://gerrit.cloudera.org:8080/#/c/8102/11/testdata/workloads/tpcds/queries/tpcds-q85.test File testdata/workloads/tpcds/queries/tpcds-q85.test: http://gerrit.cloudera.org:8080/#/c/8102/11/testdata/workloads/tpcds/queries/tpcds-q85.test@5 PS11, Line 5: select substr(r_reason_desc,1,20) Is there a separate work item added to add reason? -- To view, visit http://gerrit.cloudera.org:8080/8102 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e284888600a7a69d1f23fcb7dac21cbb13b7d66 Gerrit-Change-Number: 8102 Gerrit-PatchSet: 11 Gerrit-Owner: Tim Wood <tw...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Matthew Mulder <mmul...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-Reviewer: Tim Wood <tw...@cloudera.com> Gerrit-Comment-Date: Fri, 13 Oct 2017 04:44:46 +0000 Gerrit-HasComments: Yes
