Tim Wood has posted comments on this change. ( http://gerrit.cloudera.org:8080/8102 )
Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for Impala. ...................................................................... Patch Set 18: (5 comments) http://gerrit.cloudera.org:8080/#/c/8102/17/testdata/workloads/tpcds/queries/tpcds-q28.test File testdata/workloads/tpcds/queries/tpcds-q28.test: http://gerrit.cloudera.org:8080/#/c/8102/17/testdata/workloads/tpcds/queries/tpcds-q28.test@6 PS17, Line 6: > ss_list_price is decimal(7,2) why is the truncate required here? Query removed from this commit. http://gerrit.cloudera.org:8080/#/c/8102/12/testdata/workloads/tpcds/queries/tpcds-q31.test File testdata/workloads/tpcds/queries/tpcds-q31.test: http://gerrit.cloudera.org:8080/#/c/8102/12/testdata/workloads/tpcds/queries/tpcds-q31.test@4 PS12, Line 4: > Why did this query get taken out? See commit msg. (IMPALA-5956). http://gerrit.cloudera.org:8080/#/c/8102/12/testdata/workloads/tpcds/queries/tpcds-q31.test@20 PS12, Line 20: > Also why is truncate here needed? Ack http://gerrit.cloudera.org:8080/#/c/8102/12/testdata/workloads/tpcds/queries/tpcds-q5a.test File testdata/workloads/tpcds/queries/tpcds-q5a.test: http://gerrit.cloudera.org:8080/#/c/8102/12/testdata/workloads/tpcds/queries/tpcds-q5a.test@3 PS12, Line 3: > Why is TPCDS-5A removed? @pytest.mark.skip(reason="Unsupported in Impala") def test_tpcds_q5(self, vector): ... http://gerrit.cloudera.org:8080/#/c/8102/11/testdata/workloads/tpcds/queries/tpcds-q85.test File testdata/workloads/tpcds/queries/tpcds-q85.test: http://gerrit.cloudera.org:8080/#/c/8102/11/testdata/workloads/tpcds/queries/tpcds-q85.test@5 PS11, Line 5: > Is there a separate work item added to add reason? IMPALA-5960. -- To view, visit http://gerrit.cloudera.org:8080/8102 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e284888600a7a69d1f23fcb7dac21cbb13b7d66 Gerrit-Change-Number: 8102 Gerrit-PatchSet: 18 Gerrit-Owner: Tim Wood <tw...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Matthew Mulder <mmul...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-Reviewer: Tim Wood <tw...@cloudera.com> Gerrit-Comment-Date: Fri, 20 Oct 2017 00:23:20 +0000 Gerrit-HasComments: Yes