Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8211 )
Change subject: IMPALA-5243: Speed up code gen for wide Avro tables. ...................................................................... Patch Set 3: Code-Review+2 (4 comments) Only nits, thanks for your patience. http://gerrit.cloudera.org:8080/#/c/8211/3/be/src/exec/hdfs-avro-scanner.h File be/src/exec/hdfs-avro-scanner.h: http://gerrit.cloudera.org:8080/#/c/8211/3/be/src/exec/hdfs-avro-scanner.h@241 PS3, Line 241: const SchemaPath& path, const AvroSchemaElement& record, int child_start, int child_end, long line http://gerrit.cloudera.org:8080/#/c/8211/3/be/src/exec/hdfs-avro-scanner.cc File be/src/exec/hdfs-avro-scanner.cc: http://gerrit.cloudera.org:8080/#/c/8211/3/be/src/exec/hdfs-avro-scanner.cc@856 PS3, Line 856: BasicBlock* helper_block = BasicBlock::Create(context, "helper_" + std::to_string(i), fn, nullptr); Long line http://gerrit.cloudera.org:8080/#/c/8211/3/be/src/exec/hdfs-avro-scanner.cc@867 PS3, Line 867: Value* helper_ok = builder.CreateCall(fnHelper, args, "helper_" + std::to_string(i)); Long line. http://gerrit.cloudera.org:8080/#/c/8211/3/be/src/exec/hdfs-avro-scanner.cc@889 PS3, Line 889: const SchemaPath& path, const AvroSchemaElement& record, int child_start, int child_end, HdfsScanNodeBase* node, long line. -- To view, visit http://gerrit.cloudera.org:8080/8211 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f1b390be4adf6e6699a18344234f8ff7ee74476 Gerrit-Change-Number: 8211 Gerrit-PatchSet: 3 Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 20 Oct 2017 23:26:08 +0000 Gerrit-HasComments: Yes
