Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8211 )
Change subject: IMPALA-5243: Speed up code gen for wide Avro tables. ...................................................................... Patch Set 7: Code-Review+1 Carrying the +1. I've not made any changes here (except rebases). I've run the core tests successfully. I had run into https://issues.apache.org/jira/browse/IMPALA-6118 and https://issues.apache.org/jira/browse/IMPALA-6106 in previous testing. I didn't see any evidence that this change breaks the build specifically. The specific failed GVO build had the following assertion. That's IMPALA-6099, which is also reasonably unrelated to the Avro-only changes here. F1023 19:06:33.677640 43548 filter-context.cc:49] Check failed: it != counters.end() Tried to increment unknown counter group *** Check failure stack trace: *** @ 0x2f1e11d google::LogMessage::Fail() F1023 19:06:33.677934 43350 filter-context.cc:49] Check failed: it != counters.end() Tried to increment unknown counter group *** Check failure stack trace: *** @ 0x2f1f9c2 google::LogMessage::SendToLog() @ 0x2f1daf7 google::LogMessage::Flush() @ 0x2f1e11d google::LogMessage::Fail() @ 0x2f210be google::LogMessageFatal::~LogMessageFatal() @ 0x2f1f9c2 google::LogMessage::SendToLog() @ 0x1ca4d99 impala::FilterStats::IncrCounters() @ 0x1ca72a4 impala::FilterContext::CheckForAlwaysFalse() @ 0x2f1daf7 google::LogMessage::Flush() @ 0x1aa537d impala::HdfsScanNodeBase::PartitionPassesFilters() @ 0x2f210be google::LogMessageFatal::~LogMessageFatal() @ 0x1b0c9c6 impala::HdfsParquetScanner::GetNextInternal() @ 0x1ca4d99 impala::FilterStats::IncrCounters() @ 0x1b0acca impala::HdfsParquetScanner::ProcessSplit() @ 0x1a99cc0 impala::HdfsScanNode::ProcessSplit() @ 0x1ca72a4 impala::FilterContext::CheckForAlwaysFalse() @ 0x1a99136 impala::HdfsScanNode::ScannerThread() @ 0x1a985d3 _ZZN6impala12HdfsScanNode22ThreadTokenAvailableCbEPNS_17ThreadResourceMgr12ResourcePoolEENKUlvE_clEv @ 0x1aa537d impala::HdfsScanNodeBase::PartitionPassesFilters() @ 0x1a9a501 _ZN5boost6detail8function26void_function_obj_invoker0IZN6impala12HdfsScanNode22ThreadTokenAvailableCbEPNS3_17ThreadResourceMgr12ResourcePoolEEUlvE_vE6invokeERNS1_15function_bufferE @ 0x171bdfc boost::function0<>::operator()() @ 0x1b0c9c6 impala::HdfsParquetScanner::GetNextInternal() @ 0x19f3393 impala::Thread::SuperviseThread() @ 0x1b0acca impala::HdfsParquetScanner::ProcessSplit() @ 0x19fbf26 boost::_bi::list4<>::operator()<>() @ 0x1a99cc0 impala::HdfsScanNode::ProcessSplit() @ 0x19fbe69 boost::_bi::bind_t<>::operator()() @ 0x19fbe2c boost::detail::thread_data<>::run() @ 0x1a99136 impala::HdfsScanNode::ScannerThread() @ 0x1a985d3 _ZZN6impala12HdfsScanNode22ThreadTokenAvailableCbEPNS_17ThreadResourceMgr12ResourcePoolEENKUlvE_clEv @ 0x20a7c9a thread_proxy @ 0x1a9a501 _ZN5boost6detail8function26void_function_obj_invoker0IZN6impala12HdfsScanNode22ThreadTokenAvailableCbEPNS3_17ThreadResourceMgr12ResourcePoolEEUlvE_vE6invokeERNS1_15function_bufferE @ 0x7f0cd8e3a6ba start_thread @ 0x7f0cd8b703dd clone -- To view, visit http://gerrit.cloudera.org:8080/8211 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f1b390be4adf6e6699a18344234f8ff7ee74476 Gerrit-Change-Number: 8211 Gerrit-PatchSet: 7 Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 27 Oct 2017 16:17:28 +0000 Gerrit-HasComments: No
