Philip Zeyliger has posted comments on this change. (
http://gerrit.cloudera.org:8080/8211 )
Change subject: IMPALA-5243: Speed up code gen for wide Avro tables.
......................................................................
Patch Set 4:
(4 comments)
Thanks. I think I got all the long lines out.
"git show | egrep '^\+.{91}' | grep -v '^+//'" doesn't return anything any
more. (Obviously, we're not wrapping the example codegen.)
http://gerrit.cloudera.org:8080/#/c/8211/3/be/src/exec/hdfs-avro-scanner.h
File be/src/exec/hdfs-avro-scanner.h:
http://gerrit.cloudera.org:8080/#/c/8211/3/be/src/exec/hdfs-avro-scanner.h@241
PS3, Line 241: const SchemaPath& path, const AvroSchemaElement& record,
int child_start,
> long line
Done
http://gerrit.cloudera.org:8080/#/c/8211/3/be/src/exec/hdfs-avro-scanner.cc
File be/src/exec/hdfs-avro-scanner.cc:
http://gerrit.cloudera.org:8080/#/c/8211/3/be/src/exec/hdfs-avro-scanner.cc@856
PS3, Line 856: BasicBlock* helper_block = BasicBlock::Create(
> Long line
Done
http://gerrit.cloudera.org:8080/#/c/8211/3/be/src/exec/hdfs-avro-scanner.cc@867
PS3, Line 867: Function* fnHelper = helper_functions[i];
> Long line.
Done
http://gerrit.cloudera.org:8080/#/c/8211/3/be/src/exec/hdfs-avro-scanner.cc@889
PS3, Line 889:
> long line.
Done
--
To view, visit http://gerrit.cloudera.org:8080/8211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f1b390be4adf6e6699a18344234f8ff7ee74476
Gerrit-Change-Number: 8211
Gerrit-PatchSet: 4
Gerrit-Owner: Philip Zeyliger <[email protected]>
Gerrit-Reviewer: Philip Zeyliger <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Comment-Date: Sun, 22 Oct 2017 04:13:44 +0000
Gerrit-HasComments: Yes
