Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8344 )
Change subject: IMPALA-5018: Error on decimal modulo or divide by zero ...................................................................... Patch Set 3: > I spoke to Greg and Alex yesterday, and we agreed that decimal_v2 > should always be in strict mode. This means that when decimal_v2 is > enabled, we should always error on overflows and division by zero. > This is the behavior that more traditional databases have. I agree with that. -- To view, visit http://gerrit.cloudera.org:8080/8344 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If7a7131e657fcdd293ade78d62f851dac0f1e3eb Gerrit-Change-Number: 8344 Gerrit-PatchSet: 3 Gerrit-Owner: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Reviewer: Zach Amsden <zams...@cloudera.com> Gerrit-Comment-Date: Mon, 23 Oct 2017 16:32:51 +0000 Gerrit-HasComments: No
