Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8344 )
Change subject: IMPALA-5018: Error on decimal modulo or divide by zero ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/8344/3/be/src/exprs/decimal-operators-ir.cc File be/src/exprs/decimal-operators-ir.cc: http://gerrit.cloudera.org:8080/#/c/8344/3/be/src/exprs/decimal-operators-ir.cc@729 PS3, Line 729: divide this path will also be taken for modulo. Should the message take that into account to avoid confusion? http://gerrit.cloudera.org:8080/#/c/8344/3/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: http://gerrit.cloudera.org:8080/#/c/8344/3/be/src/exprs/expr-test.cc@2264 PS3, Line 2264: { true, false, 0, 38, 19 }}}, it would be good to test also 10.0 / 0 or cast(10.0 as decimal) / 0 (i.e. where divisor is integer not decimal). I don't remember what type that expressino would have had in decimal v1 though. Added a comment to pytest about this too, which might be the easier place to verify. http://gerrit.cloudera.org:8080/#/c/8344/3/be/src/exprs/expr-test.cc@2506 PS3, Line 2506: 0/0 it's a bit weird/confusing that we don't do the same thing for integer divide by 0, but I guess it's out of scope. http://gerrit.cloudera.org:8080/#/c/8344/3/testdata/workloads/functional-query/queries/QueryTest/decimal-exprs.test File testdata/workloads/functional-query/queries/QueryTest/decimal-exprs.test: http://gerrit.cloudera.org:8080/#/c/8344/3/testdata/workloads/functional-query/queries/QueryTest/decimal-exprs.test@46 PS3, Line 46: cast is that cast necessary? Let's also verify you get the error without the cast there. -- To view, visit http://gerrit.cloudera.org:8080/8344 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If7a7131e657fcdd293ade78d62f851dac0f1e3eb Gerrit-Change-Number: 8344 Gerrit-PatchSet: 3 Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-Comment-Date: Mon, 23 Oct 2017 16:49:30 +0000 Gerrit-HasComments: Yes
