Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8358 )
Change subject: IMPALA-6004: Fix test_row_filters failure on ASAN ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8358/1/testdata/workloads/functional-query/queries/QueryTest/runtime_row_filters.test File testdata/workloads/functional-query/queries/QueryTest/runtime_row_filters.test: http://gerrit.cloudera.org:8080/#/c/8358/1/testdata/workloads/functional-query/queries/QueryTest/runtime_row_filters.test@350 PS1, Line 350: SET RUNTIME_FILTER_WAIT_TIME_MS=100000; Do you think it makes sense to have different timeouts for each different test case in this file? If not, we should consider using the same timeout everywhere in this test and set the query option based on solution like this: https://gerrit.cloudera.org/#/c/8357 -- To view, visit http://gerrit.cloudera.org:8080/8358 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia098735594b36a72f02bf7edd051171689618051 Gerrit-Change-Number: 8358 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Comment-Date: Mon, 23 Oct 2017 18:58:38 +0000 Gerrit-HasComments: Yes
