Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8358 )
Change subject: IMPALA-6004: Fix test_row_filters failure on ASAN ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/8358/1/testdata/workloads/functional-query/queries/QueryTest/runtime_row_filters.test File testdata/workloads/functional-query/queries/QueryTest/runtime_row_filters.test: http://gerrit.cloudera.org:8080/#/c/8358/1/testdata/workloads/functional-query/queries/QueryTest/runtime_row_filters.test@350 PS1, Line 350: SET RUNTIME_FILTER_WAIT_TIME_MS=$RUNTIME_FILTER_WAIT_TIME_MS; > Its not really necessary. There's one case (14) that seems to legitimately Thanks for making this change. I agree it's maybe not strictly necessary, but fine-tuning the timeout on a case-by-case basis has already caused many build failures and subsequent fixes to bump the timeouts. I'm hoping that this blanket configuration will ultimately be more stable. -- To view, visit http://gerrit.cloudera.org:8080/8358 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia098735594b36a72f02bf7edd051171689618051 Gerrit-Change-Number: 8358 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Wed, 25 Oct 2017 05:05:28 +0000 Gerrit-HasComments: Yes
