Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/8358 )
Change subject: IMPALA-6004: Fix test_row_filters failure on ASAN ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8358/1/testdata/workloads/functional-query/queries/QueryTest/runtime_row_filters.test File testdata/workloads/functional-query/queries/QueryTest/runtime_row_filters.test: http://gerrit.cloudera.org:8080/#/c/8358/1/testdata/workloads/functional-query/queries/QueryTest/runtime_row_filters.test@350 PS1, Line 350: SET RUNTIME_FILTER_WAIT_TIME_MS=$RUNTIME_FILTER_WAIT_TIME_MS; > Do you think it makes sense to have different timeouts for each different t Its not really necessary. There's one case (14) that seems to legitimately need more time than the others, but I don't see why its a problem to just have all the tests run with enough time for the slowest. (14 is currently set to 100s, but testing locally its only about 30% slower than the tests that are set to 30s, so I sort of split the difference with the new version of the patch). -- To view, visit http://gerrit.cloudera.org:8080/8358 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia098735594b36a72f02bf7edd051171689618051 Gerrit-Change-Number: 8358 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Mon, 23 Oct 2017 20:48:44 +0000 Gerrit-HasComments: Yes
