Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 )
Change subject: IMPALA-4704: Turns on client connections when local catalog initialized. ...................................................................... Patch Set 11: Code-Review+1 (1 comment) BE looks fine. http://gerrit.cloudera.org:8080/#/c/8202/11/be/src/service/frontend.cc File be/src/service/frontend.cc: http://gerrit.cloudera.org:8080/#/c/8202/11/be/src/service/frontend.cc@242 PS11, Line 242: Status Frontend::SetCatalogInitialized() { : JNIEnv* jni_env = getJNIEnv(); : JniLocalFrame jni_frame; : RETURN_IF_ERROR(jni_frame.push(jni_env)); : jni_env->CallObjectMethod(fe_, set_catalog_initialized_id_); : RETURN_ERROR_IF_EXC(jni_env); : return Status::OK(); : } is that needed? could it be handled entirely within InProcessImpalaServer? Maybe orthogonal to this change to so okay to defer. -- To view, visit http://gerrit.cloudera.org:8080/8202 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I52b881cba18a7e4533e21a78751c2e35c3d4c8a6 Gerrit-Change-Number: 8202 Gerrit-PatchSet: 11 Gerrit-Owner: Vuk Ercegovac <[email protected]> Gerrit-Reviewer: Balazs Jeszenszky <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Mon, 23 Oct 2017 19:01:40 +0000 Gerrit-HasComments: Yes
