Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 )
Change subject: IMPALA-4704: Turns on client connections when local catalog initialized. ...................................................................... Patch Set 11: (9 comments) http://gerrit.cloudera.org:8080/#/c/8202/11/bin/start-impala-cluster.py File bin/start-impala-cluster.py: http://gerrit.cloudera.org:8080/#/c/8202/11/bin/start-impala-cluster.py@258 PS11, Line 258: return not impala_cluster.catalogd and not options.disable_catalog Why not: return impala_cluster.catalogd or options.disable_catalog http://gerrit.cloudera.org:8080/#/c/8202/11/bin/start-impala-cluster.py@317 PS11, Line 317: ; remove stray semicolon http://gerrit.cloudera.org:8080/#/c/8202/11/bin/start-impala-cluster.py@323 PS11, Line 323: client_beeswax.close() What about closing the HS2 client? http://gerrit.cloudera.org:8080/#/c/8202/11/bin/start-impala-cluster.py@327 PS11, Line 327: Client ports within %s seconds.' % timeout_in_seconds Can we make this error message clearer? "Client ports not ready within N seconds", for instance. http://gerrit.cloudera.org:8080/#/c/8202/11/bin/start-impala-cluster.py@407 PS11, Line 407: # Check for the cluster to be ready only when the catalog was started. : if not options.disable_catalog: : wait_for_cluster() Is this too lax? Can we not call wait_for_impala_process_count()? http://gerrit.cloudera.org:8080/#/c/8202/11/tests/custom_cluster/test_catalog_wait.py File tests/custom_cluster/test_catalog_wait.py: http://gerrit.cloudera.org:8080/#/c/8202/11/tests/custom_cluster/test_catalog_wait.py@26 PS11, Line 26: cls Nit: This is a bound object method, so the first argument here is going to be the object, not the class. Use the name "self" here. http://gerrit.cloudera.org:8080/#/c/8202/11/tests/custom_cluster/test_catalog_wait.py@28 PS11, Line 28: cls self http://gerrit.cloudera.org:8080/#/c/8202/11/tests/custom_cluster/test_catalog_wait.py@30 PS11, Line 30: cls self here and below as well http://gerrit.cloudera.org:8080/#/c/8202/11/tests/custom_cluster/test_catalog_wait.py@45 PS11, Line 45: with pytest.raises(Exception) as e nice! -- To view, visit http://gerrit.cloudera.org:8080/8202 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I52b881cba18a7e4533e21a78751c2e35c3d4c8a6 Gerrit-Change-Number: 8202 Gerrit-PatchSet: 11 Gerrit-Owner: Vuk Ercegovac <[email protected]> Gerrit-Reviewer: Balazs Jeszenszky <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Mon, 23 Oct 2017 19:10:37 +0000 Gerrit-HasComments: Yes
