Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 )
Change subject: IMPALA-4704: Turns on client connections when local catalog initialized. ...................................................................... Patch Set 11: (13 comments) http://gerrit.cloudera.org:8080/#/c/8202/11/be/src/service/frontend.cc File be/src/service/frontend.cc: http://gerrit.cloudera.org:8080/#/c/8202/11/be/src/service/frontend.cc@242 PS11, Line 242: Status Frontend::SetCatalogInitialized() { : JNIEnv* jni_env = getJNIEnv(); : JniLocalFrame jni_frame; : RETURN_IF_ERROR(jni_frame.push(jni_env)); : jni_env->CallObjectMethod(fe_, set_catalog_initialized_id_); : RETURN_ERROR_IF_EXC(jni_env); : return Status::OK(); : } > is that needed? could it be handled entirely within InProcessImpalaServer? its also used by expr-benchmark as well, which instantiates its own frontend class (case of neither InProcess nor daemon). there's probably some simplification here, but yes, I agree that its orthogonal. http://gerrit.cloudera.org:8080/#/c/8202/11/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/8202/11/be/src/service/impala-server.cc@1979 PS11, Line 1979: // Wait for the frontend catalog to be ready prior to opening client ports. > nit: Maybe expand this comment to mention that this call will block indefin Done http://gerrit.cloudera.org:8080/#/c/8202/11/bin/start-impala-cluster.py File bin/start-impala-cluster.py: http://gerrit.cloudera.org:8080/#/c/8202/11/bin/start-impala-cluster.py@82 PS11, Line 82: action="store_true", : help=SUPPRESS_HELP) > nit: merge these two and save a line :) Done http://gerrit.cloudera.org:8080/#/c/8202/11/bin/start-impala-cluster.py@258 PS11, Line 258: return not impala_cluster.catalogd and not options.disable_catalog > Why not: Done http://gerrit.cloudera.org:8080/#/c/8202/11/bin/start-impala-cluster.py@304 PS11, Line 304: wait_for_client > I think this should be named wait_for_catalog since that is the high level this method additionally waits for the client ports to be opened. changed the name and the comment to clarify. http://gerrit.cloudera.org:8080/#/c/8202/11/bin/start-impala-cluster.py@317 PS11, Line 317: ; > remove stray semicolon Done. Is there a python linter that folks use to catch cases like this? http://gerrit.cloudera.org:8080/#/c/8202/11/bin/start-impala-cluster.py@323 PS11, Line 323: client_beeswax.close() > What about closing the HS2 client? it does not have a close afaict. http://gerrit.cloudera.org:8080/#/c/8202/11/bin/start-impala-cluster.py@327 PS11, Line 327: Client ports within %s seconds.' % timeout_in_seconds > Can we make this error message clearer? "Client ports not ready within N s Done http://gerrit.cloudera.org:8080/#/c/8202/11/bin/start-impala-cluster.py@407 PS11, Line 407: # Check for the cluster to be ready only when the catalog was started. : if not options.disable_catalog: : wait_for_cluster() > Is this too lax? Can we not call wait_for_impala_process_count()? simplified... wait for cluster should do the right thing when the cluster is started with out the catalog. http://gerrit.cloudera.org:8080/#/c/8202/11/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/8202/11/tests/common/custom_cluster_test_suite.py@127 PS11, Line 127: if disable_catalog: : cmd.append("--disable_catalog") > nit: single line Done http://gerrit.cloudera.org:8080/#/c/8202/11/tests/custom_cluster/test_catalog_wait.py File tests/custom_cluster/test_catalog_wait.py: http://gerrit.cloudera.org:8080/#/c/8202/11/tests/custom_cluster/test_catalog_wait.py@26 PS11, Line 26: cls > Nit: This is a bound object method, so the first argument here is going to Done http://gerrit.cloudera.org:8080/#/c/8202/11/tests/custom_cluster/test_catalog_wait.py@28 PS11, Line 28: cls > self Done http://gerrit.cloudera.org:8080/#/c/8202/11/tests/custom_cluster/test_catalog_wait.py@30 PS11, Line 30: cls > self here and below as well Done -- To view, visit http://gerrit.cloudera.org:8080/8202 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I52b881cba18a7e4533e21a78751c2e35c3d4c8a6 Gerrit-Change-Number: 8202 Gerrit-PatchSet: 11 Gerrit-Owner: Vuk Ercegovac <[email protected]> Gerrit-Reviewer: Balazs Jeszenszky <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Mon, 23 Oct 2017 21:21:14 +0000 Gerrit-HasComments: Yes
