jt2594838 commented on a change in pull request #429: [IOTDB-205]Support
storage-group-level data ttl
URL: https://github.com/apache/incubator-iotdb/pull/429#discussion_r338368409
##########
File path: server/src/main/java/org/apache/iotdb/db/service/TSServiceImpl.java
##########
@@ -309,7 +310,7 @@ public TSFetchMetadataResp
fetchMetadata(TSFetchMetadataReq req) {
status = new TSStatus(getStatus(TSStatusCode.SUCCESS_STATUS));
break;
case "SHOW_STORAGE_GROUP":
- Set<String> storageGroups = getAllStorageGroups();
+ Set<String> storageGroups = new HashSet<>(getAllStorageGroups());
Review comment:
The data structure required by the upper interface is a `Set`, while the
lower interface returns a `List`, so I have to do the conversion.
But actually, it does not need to be a set, as we won't have duplicated SGs.
I will change the upper interface to receive a `List` later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services