jt2594838 commented on a change in pull request #429: [IOTDB-205]Support
storage-group-level data ttl
URL: https://github.com/apache/incubator-iotdb/pull/429#discussion_r339512627
##########
File path:
server/src/main/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessor.java
##########
@@ -387,6 +408,15 @@ public boolean insert(InsertPlan insertPlan) throws
QueryProcessorException {
}
}
+ /**
+ *
+ * @param time
+ * @return whether the given time falls in ttl
+ */
+ private boolean checkTTL(long time) {
+ return dataTTL == Long.MAX_VALUE || (System.currentTimeMillis() - time) <=
dataTTL;
Review comment:
I can't see what makes it "better", and there is no merit in doing so,
persuade me, please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
