jt2594838 commented on a change in pull request #429: [IOTDB-205]Support storage-group-level data ttl URL: https://github.com/apache/incubator-iotdb/pull/429#discussion_r339512128
########## File path: server/src/main/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessor.java ########## @@ -178,6 +182,12 @@ private LinkedList<String> lruForSensorUsedInQuery = new LinkedList<>(); private static final int MAX_CACHE_SENSORS = 5000; + /** + * when the data in a storage group is older than dataTTL, it is considered invalid and will + * be eventually removed. + */ + private long dataTTL = Long.MAX_VALUE; Review comment: I can't your point. There is only `dataTTL` in SGProcessor and `timeLowerBound` in TsFileResource is derived from it. They are playing different roles and I cannot only use one of them. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
