jt2594838 commented on a change in pull request #429: [IOTDB-205]Support
storage-group-level data ttl
URL: https://github.com/apache/incubator-iotdb/pull/429#discussion_r339513401
##########
File path:
server/src/main/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessor.java
##########
@@ -387,6 +408,15 @@ public boolean insert(InsertPlan insertPlan) throws
QueryProcessorException {
}
}
+ /**
+ *
+ * @param time
+ * @return whether the given time falls in ttl
+ */
+ private boolean checkTTL(long time) {
Review comment:
Even though it only serves for insertion now, this method is not logically
bound to insert, so I would prefer its current name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
