Pengzna commented on code in PR #11410:
URL: https://github.com/apache/iotdb/pull/11410#discussion_r1375878988
##########
iotdb-core/metrics/core/src/main/java/org/apache/iotdb/metrics/core/type/IoTDBTimer.java:
##########
@@ -39,11 +40,46 @@ public void update(long duration, TimeUnit unit) {
@Override
public HistogramSnapshot takeSnapshot() {
- return new MicrometerTimerHistogramSnapshot(timer);
+ return new IoTDBTimerHistogramSnapshot(timer);
}
@Override
public long getCount() {
+ return this.count();
+ }
+
+ @Override
+ public double getSum() {
+ return this.takeSnapshot().getSum();
+ }
+
+ @Override
+ public double getMax() {
+ return this.takeSnapshot().getMax();
+ }
+
+ @Override
+ public double getMean() {
+ return this.takeSnapshot().getMean();
Review Comment:
Have fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
