Pengzna commented on code in PR #11410:
URL: https://github.com/apache/iotdb/pull/11410#discussion_r1375891950


##########
iotdb-core/metrics/interface/src/main/java/org/apache/iotdb/metrics/impl/DoNothingGauge.java:
##########
@@ -41,4 +43,9 @@ public void decr(long value) {
   public void set(long value) {
     // do nothing
   }
+
+  @Override
+  public void setObjectName(ObjectName objectName) {

Review Comment:
   Yes, it's a good point and acctually we have already done that. For every 
metric type, an AbstractClass is designed to implement this method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to