Pengzna commented on code in PR #11410:
URL: https://github.com/apache/iotdb/pull/11410#discussion_r1376062826
##########
iotdb-core/metrics/core/src/main/java/org/apache/iotdb/metrics/core/type/IoTDBAutoGaugeMBean.java:
##########
@@ -17,29 +17,25 @@
* under the License.
*/
-package org.apache.iotdb.metrics.micrometer.type;
+package org.apache.iotdb.metrics.core.type;
-import org.apache.iotdb.metrics.type.Counter;
+import javax.management.ObjectName;
-public class MicrometerCounter implements Counter {
- io.micrometer.core.instrument.Counter counter;
+public interface IoTDBAutoGaugeMBean {
+ ObjectName objectName();
- public MicrometerCounter(io.micrometer.core.instrument.Counter counter) {
- this.counter = counter;
- }
+ double getValue();
- @Override
- public void inc() {
- counter.increment();
- }
+ abstract class AbstractJmxAutoGaugeBean implements IoTDBAutoGaugeMBean {
Review Comment:
Good idea! Have fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
