JackieTien97 commented on code in PR #17843:
URL: https://github.com/apache/iotdb/pull/17843#discussion_r3377279342
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/analyzer/StatementAnalyzer.java:
##########
@@ -367,6 +367,74 @@ private enum UpdateKind {
MERGE,
}
+ private static final class SelectAnalysis {
+ private final List<Expression> outputExpressions;
+ private final List<SelectAlias> aliases;
+
+ private SelectAnalysis(List<Expression> outputExpressions,
List<SelectAlias> aliases) {
+ this.outputExpressions =
+ ImmutableList.copyOf(requireNonNull(outputExpressions,
"outputExpressions is null"));
+ this.aliases = ImmutableList.copyOf(requireNonNull(aliases, "aliases is
null"));
+ }
+
+ private List<Expression> getOutputExpressions() {
+ return outputExpressions;
+ }
+
+ private List<SelectAlias> getAliases() {
+ return aliases;
+ }
+ }
+
+ private static final class SelectAlias {
+ private final String canonicalName;
+ private final Expression expression;
Review Comment:
no need to store this? For `resolveGroupBySelectAlias`, we only need
`position` too. With `position`, you can just pick expression from
`outputExpressions` just like previous `LongLiteral`
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/analyzer/StatementAnalyzer.java:
##########
@@ -4102,11 +4212,16 @@ private FieldReference getFieldReferenceForFillGroup(
}
private List<Expression> analyzeOrderBy(
- Node node, List<SortItem> sortItems, Scope orderByScope) {
+ Node node,
+ List<SortItem> sortItems,
+ Scope sourceScope,
+ Scope orderByScope,
Review Comment:
why we need another `sourceScope`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
