DaZuiZui commented on PR #17843: URL: https://github.com/apache/iotdb/pull/17843#issuecomment-4657163415
Thanks @Caideyipi , @JackieTien97 for the careful review! I’ve addressed the comments in the latest commits: - Fixed SELECT alias resolution for GROUP BY ROLLUP / CUBE / GROUPING SETS, including resolved-expression mapping for grouping sets. - Restored ORDER BY analysis to use orderByScope by default, while preserving explicit SELECT alias precedence. - Simplified SelectAlias to store only the canonical alias name and output position. - Added/updated analyzer UT coverage in SelectAliasReuseTest, including the ORDER BY window alias regression case. - Added table-model IT coverage in IoTDBTableAggregationIT. I also verified the fix locally with: - SelectAliasReuseTest - IoTDBTableAggregationIT#selectAliasInGroupByAndOrderByTest - spotless for datanode and integration-test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
