JackieTien97 commented on code in PR #17843:
URL: https://github.com/apache/iotdb/pull/17843#discussion_r3379346911
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/analyzer/StatementAnalyzer.java:
##########
@@ -4102,11 +4210,12 @@ private FieldReference getFieldReferenceForFillGroup(
}
private List<Expression> analyzeOrderBy(
- Node node, List<SortItem> sortItems, Scope orderByScope) {
+ Node node, List<SortItem> sortItems, Scope orderByScope,
List<SelectAlias> selectAliases) {
ImmutableList.Builder<Expression> orderByFieldsBuilder =
ImmutableList.builder();
for (SortItem item : sortItems) {
Expression expression = item.getSortKey();
+ Scope expressionScope = orderByScope;
Review Comment:
I don't understand why we still need this? It seems that it will always be
`orderByScope`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
